fix: anyOf/oneOf missing properties for intersection/inheritance #5930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
baywet
requested changes
Dec 23, 2024
vipentti
force-pushed
the
fix/single-one-of-all-of-merge
branch
from
9956de6 to
bb00147
Compare
baywet
previously approved these changes
Dec 24, 2024
auto-merge was automatically disabled
December 24, 2024 14:53
Head branch was pushed to by a user without write access
vipentti
force-pushed
the
fix/single-one-of-all-of-merge
branch
from
bb00147 to
5094aaa
Compare
|
Looks like there were some formatting issues which caused the build to fail, I have now fixed those. For some reason the OpenApiSchemaExtensionsTests did not report any issues locally when running |
baywet
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds these scenarios as specific cases in
KiotaBuilder.CreateModelDeclarations. Not sure if this is the best place to handle this but at least this fixes the issue where the properties & possible inheritance were completely missing while not breaking anything existing.Fixes #5921